Move knative-local-gateway service to istio-system. #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 81.32% 81.26% -0.06%
==========================================
Files 15 15
Lines 1012 1009 -3
==========================================
- Hits 823 820 -3
Misses 110 110
Partials 79 79
Continue to review full report at Codecov.
|
04c578c to
251eb1f
Compare
|
@ZhiminXiang can you please help review this? Thanks |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JRBANCEL, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a fatal in my plan to collocate both Ingress and Local Gateways into the same Envoy Pods: k8s service selectors only work inside the same namespace (the Envoy Pods are in
istio-system).This moves the
knative-local-gatewayk8s service toistio-system, this is fine because this service is not being used yet (see phase #2 of the plan).Also, this addresses @mattmoor comment about using
network.GetServiceHostname.