8000 Add S-Mann as a member to the knative group by S-Mann · Pull Request #1693 · knative/community · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add S-Mann as a member to the knative group #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

S-Mann
Copy link
@S-Mann S-Mann commented Jun 20, 2025

Changes

Request to add myself to the knative group so I don't need to wait to run further tests on PRs.

My contributions so far have been:

support for additional pod scheduling definition on IntegrationSource

Signed-off-by: S-Mann <29407727+S-Mann@users.noreply.github.com>
Copy link
knative-prow bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: S-Mann
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso and nrrso June 20, 2025 21:31
Copy link
knative-prow bot commented Jun 20, 2025

Welcome @S-Mann! It looks like this is your first PR to knative/community 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2025
Copy link
knative-prow bot commented Jun 20, 2025

Hi @S-Mann. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2025
@dprotaso
Copy link
Member

/assign @Cali0707 @creydr @matzew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0