8000 use PullIfNotPresent so works with kind by vaikas · Pull Request #4317 · knative/eventing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ eventing Public

use PullIfNotPresent so works with kind #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2020
Merged

use PullIfNotPresent so works with kind #4317

merged 2 commits into from
Oct 15, 2020

Conversation

vaikas
Copy link
Contributor
@vaikas vaikas commented Oct 14, 2020

Fixes #

Proposed Changes

  • For the e2e tests, use PullIfNotPresent so it works with kind.

Release Note

- 🐛 Fix bug
Change the image pull policy so sinkbinding source tests work with kind.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 14, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Oct 14, 2020
@codecov
Copy link
codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #4317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4317   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         288      288           
  Lines        7910     7910           
=======================================
  Hits         6357     6357           
  Misses       1172     1172           
  Partials      381      381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889429...844e131. Read the comment docs.

@matzew
Copy link
Member
matzew commented Oct 14, 2020

Why is that not needed ?

eventing/test/e2e/source_sinkbinding_v1_test.go

Line 184 in 2755949

ImagePullPolicy: corev1.PullAlways,

@slinkydeveloper
8000 Copy link
Contributor
slinkydeveloper commented Oct 14, 2020 •
edited
Loading

@vaikas this still fails on kind?!

@vaikas
Copy link
Contributor Author
vaikas commented Oct 14, 2020

Well, that was the one difference between v1 setup, so thought that might have been it:
https://github.com/google/ko

Like with minikube above, a caveat of this approach is that it will not work if your container is configured with imagePullPolicy: Always because despite having the image locally, a pull is performed to ensure we have the latest version, it still exists, and that access hasn't been revoked. A workaround for this is to use imagePullPolicy: IfNotPresent, which should work well with ko in all contexts.

@vaikas
Copy link
Contributor Author
vaikas commented Oct 14, 2020

I missed one container :(

@vaikas
Copy link
Contributor Author
vaikas commented Oct 14, 2020

Ok, back go regularly scheduled delivery flakiness.

        broker_channel_flow_helper.go:207: Assert passed
        broker_channel_flow_helper.go:208: Timeout waiting for at least 1 matches.
            Error: FAIL MATCHING: saw 0/1 matching events.
            Recent events: 
            1 events seen, last 1 events:Validation: valid
            Context Attributes,
              specversion: 1.0
              type: type1
              source: http://source1.com
              id: c25bc5b7-f278-4fb8-ac8d-919c893f4542
              datacontenttype: application/json
            Extensions,
              knativearrivaltime: 2020-10-14T13:17:58.395761344Z
              knativehistory: e2e-brokerchannel-broker-kne-trigger-kn-channel.test-broker-channel-flow-v1-beta1-broker-v1-channel-messag5jzqq.svc.c306498686.local
            Data,
              {
                "msg": "e2e-brokerchannel-body"
              }
            
            
            Match errors: 
            0 - expecting attribute 'source' equal to 'http://source2.com', got 'http://source1.com'

@vaikas
Copy link
Contributor Author
vaikas commented Oct 14, 2020

integ failed also:

=== CONT  TestEventTransformationForSubscriptionV1/InMemoryChannel-messaging.knative.dev/v1beta1
    channel_event_tranformation_test_helper.go:134: Timeout waiting for at least 4 matches.
        Error: FAIL MATCHING: saw 3/4 matching events.
        Recent events: 
        3 events seen, last 3 events:Validation: valid
        Context Attributes,
          specversion: 1.0
          type: dev.knative.test.event
          source: http://e2e-eventtransformation-sender.svc/
          id: dummy
          datacontenttype: application/json
        Extensions,
          knativehistory: e2e-eventtransformation1-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local; e2e-eventtransformation2-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local
        Data,
          {
            "msg": "eventBody 6c324bd9-8604-45d9-84c5-9e622627280e"
          }
        
        Validation: valid
        Context Attributes,
          specversion: 1.0
          type: dev.knative.test.event
          source: http://e2e-eventtransformation-sender.svc/
          id: dummy
          datacontenttype: application/json
        Extensions,
          knativehistory: e2e-eventtransformation1-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local; e2e-eventtransformation2-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local
        Data,
          {
            "msg": "eventBody 6c324bd9-8604-45d9-84c5-9e622627280e"
          }
        
        Validation: valid
        Context Attributes,
          specversion: 1.0
          type: dev.knative.test.event
          source: http://e2e-eventtransformation-sender.svc/
          id: dummy
          datacontenttype: application/json
        Extensions,
          knativehistory: e2e-eventtransformation1-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local; e2e-eventtransformation2-kn-channel.test-event-transformation-for-subscription-v1-in-memory-ch7jdtq.svc.cluster.local
        Data,
          {
            "msg": "eventBody 6c324bd9-8604-45d9-84c5-9e622627280e"
          }

@vaikas
Copy link
Contributor Author
vaikas commented Oct 14, 2020

/test pull-knative-eventing-integration-tests

@matzew
Copy link
Member
matzew commented Oct 14, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slinkydeveloper
Copy link
Contributor

/lgtm

Now it seems like it's fixed

@vaikas vaikas mentioned this pull request Oct 14, 2020
Merged
mattmoor
mattmoor reviewed Oct 14, 2020
View reviewed changes
Copy link
Member
@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vaikas
Copy link
Contributor Author
vaikas commented Oct 15, 2020

/test pull-knative-eventing-integration-tests

@vaikas vaikas mentioned this pull request Oct 15, 2020
Merged
@knative-prow-robot knative-prow-robot merged commit d8212a8 into knative:master Oct 15, 2020
@vaikas vaikas deleted the sinkbinding branch October 16, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@matzew matzew

@mattmoor mattmoor

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @matzew @slinkydeveloper @knative-prow-robot @mattmoor
0