8000 remove event emit for normal trigger reconcile by vaikas · Pull Request #3643 · knative/eventing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove event emit for normal trigger reconcile #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2020
Merged

remove event emit for normal trigger reconcile #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/reconciler/mtbroker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,6 @@ func (r *Reconciler) reconcileTriggers(ctx context.Context, b *eventingv1.Broker
if tErr != nil {
logging.FromContext(ctx).Errorw("Reconciling trigger failed:", zap.String("name", t.Name), zap.Error(err))
recorder.Eventf(trigger, corev1.EventTypeWarning, triggerReconcileFailed, "Trigger reconcile failed: %v", tErr)
} else {
recorder.Event(trigger, corev1.EventTypeNormal, triggerReconciled, "Trigger reconciled")
}
trigger.Status.ObservedGeneration = t.Generation
if _, updateStatusErr := r.updateTriggerStatus(ctx, trigger); updateStatusErr != nil {
Expand Down
32 changes: 0 additions & 32 deletions pkg/reconciler/mtbroker/broker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,6 @@ func TestReconcile(t *testing.T) {
}},
WantEvents: []string{
finalizerUpdatedEvent,
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantPatches: []clientgotesting.PatchActionImpl{
patchFinalizers(testNS, brokerName),
Expand Down Expand Up @@ -631,9 +630,6 @@ func TestReconcile(t *testing.T) {
WithInitTriggerConditions,
WithTriggerSubscriberURI(subscriberURI)),
}},
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
}, {
Name: "Trigger subscription create fails",
Key: testKey,
Expand Down Expand Up @@ -800,9 +796,6 @@ func TestReconcile(t *testing.T) {
WantCreates: []runtime.Object{
makeFilterSubscription(),
},
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
}, {
Name: "Trigger has subscriber ref exists",
Key: testKey,
Expand All @@ -813,9 +806,6 @@ func TestReconcile(t *testing.T) {
WithTriggerSubscriberRef(subscriberGVK, subscriberName, testNS),
WithInitTriggerConditions)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -843,9 +833,6 @@ func TestReconcile(t *testing.T) {
WithInitTriggerConditions,
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -873,9 +860,6 @@ func TestReconcile(t *testing.T) {
WithInitTriggerConditions,
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -925,9 +909,6 @@ func TestReconcile(t *testing.T) {
WithInitTriggerConditions,
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand All @@ -952,9 +933,6 @@ func TestReconcile(t *testing.T) {
WithInitTriggerConditions,
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -1009,8 +987,6 @@ func TestReconcile(t *testing.T) {
WithDependencyAnnotation(dependencyAnnotation),
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled")},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -1038,8 +1014,6 @@ func TestReconcile(t *testing.T) {
WithDependencyAnnotation(dependencyAnnotation),
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled")},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -1068,8 +1042,6 @@ func TestReconcile(t *testing.T) {
WithDependencyAnnotation(dependencyAnnotation),
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled")},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -1097,9 +1069,6 @@ func TestReconcile(t *testing.T) {
WithDependencyAnnotation(dependencyAnnotation),
)}...),
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerName, testNS, brokerName,
WithTriggerUID(triggerUID),
Expand Down Expand Up @@ -1131,7 +1100,6 @@ func TestReconcile(t *testing.T) {
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, subscriptionDeleted, `Deprecated subscription removed: "%s/%s"`, testNS, makeReadySubscriptionDeprecatedName(triggerNameLong, triggerUIDLong).Name),
Eventf(corev1.EventTypeNormal, "TriggerReconciled", "Trigger reconciled"),
},
WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
Object: NewTrigger(triggerNameLong, testNS, brokerName,
Expand Down
0