8000 remove reconciled normal event from mtbroker by n3wscott · Pull Request #3697 · knative/eventing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove reconciled normal event from mtbroker #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

remove reconciled normal event from mtbroker #3697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions 8000 pkg/reconciler/mtbroker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ import (
"knative.dev/pkg/system"
)

const (
// Name of the corev1.Events emitted from the Broker reconciliation process.
brokerReconciled = "BrokerReconciled"
)

type Reconciler struct {
eventingClientSet clientset.Interface
dynamicClientSet dynamic.Interface
Expand Down Expand Up @@ -96,10 +91,6 @@ type ReconcilerArgs struct {
FilterServiceAccountName string
}

func newReconciledNormal(namespace, name string) pkgreconciler.Event {
return pkgreconciler.NewEvent(corev1.EventTypeNormal, brokerReconciled, "Broker reconciled: \"%s/%s\"", namespace, name)
}

func (r *Reconciler) ReconcileKind(ctx context.Context, b *eventingv1.Broker) pkgreconciler.Event {
triggerChan, err := r.reconcileKind(ctx, b)
if err != nil {
Expand Down Expand Up @@ -268,7 +259,7 @@ func (r *Reconciler) FinalizeKind(ctx context.Context, b *eventingv1.Broker) pkg
if err := r.propagateBrokerStatusToTriggers(ctx, b.Namespace, b.Name, nil); err != nil {
return fmt.Errorf("Trigger reconcile failed: %v", err)
}
return newReconciledNormal(b.Namespace, b.Name)
return nil
}

// reconcileChannel reconciles Broker's 'b' underlying channel.
Expand Down
4 changes: 0 additions & 4 deletions pkg/reconciler/mtbroker/broker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ func TestReconcile(t *testing.T) {
WithBrokerDeletionTimestamp),
imcConfigMap(),
},
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "BrokerReconciled", `Broker reconciled: "test-namespace/test-broker"`),
},
}, {
Name: "nil config",
Key: testKey,
Expand Down Expand Up @@ -582,7 +579,6 @@ func TestReconcile(t *testing.T) {
},
WantEvents: []string{
finalizerUpdatedEvent,
Eventf(corev1.EventTypeNormal, "BrokerReconciled", `Broker reconciled: "test-namespace/test-broker"`),
},
}, {
Name: "Broker being deleted, marks trigger as not ready due to broker missing, fails",
Expand Down
0