8000 remove reconciled normal event from parallel by n3wscott · Pull Request #3698 · knative/eventing · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove reconciled normal event from parallel #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

remove reconciled normal event from parallel #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions 8000 pkg/reconciler/parallel/parallel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ import (
pkgreconciler "knative.dev/pkg/reconciler"
)

// newReconciledNormal makes a new reconciler event with event type Normal, and
// reason ParallelReconciled.
func newReconciledNormal(namespace, name string) pkgreconciler.Event {
return pkgreconciler.NewEvent(corev1.EventTypeNormal, "ParallelReconciled", "Parallel reconciled: \"%s/%s\"", namespace, name)
}

type Reconciler struct {
// listers index properties about resources
parallelLister listers.ParallelLister
Expand Down Expand Up @@ -130,7 +124,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, p *v1beta1.Parallel) pkg
}
p.Status.PropagateSubscriptionStatuses(filterSubs, subs)

return newReconciledNormal(p.Namespace, p.Name)
return nil
}

func (r *Reconciler) reconcileChannel(ctx context.Context, channelResourceInterface dynamic.ResourceInterface, p *v1beta1.Parallel, channelObjRef corev1.ObjectReference) (*duckv1beta1.Channelable, error) {
Expand Down
24 changes: 0 additions & 24 deletions pkg/reconciler/parallel/parallel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(0)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -165,9 +162,6 @@ func TestAllBranches(t *testing.T) {
{Filter: createFilter(0), Subscriber: createSubscriber(0)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -204,9 +198,6 @@ func TestAllBranches(t *testing.T) {
{Filter: createFilter(0), Subscriber: createSubscriber(0), Delivery: createDelivery(subscriberGVK, "dlc", testNS)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -244,9 +235,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(0)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -287,9 +275,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(0), Reply: createBranchReplyChannel(0)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -330,9 +315,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(1)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -390,9 +372,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(1)},
}))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantCreates: []runtime.Object{
createChannel(parallelName),
createBranchChannel(parallelName, 0),
Expand Down Expand Up @@ -456,9 +435,6 @@ func TestAllBranches(t *testing.T) {
{Subscriber: createSubscriber(0)},
})))},
WantErr: false,
WantEvents: []string{
Eventf(corev1.EventTypeNormal, "ParallelReconciled", `Parallel reconciled: "test-namespace/test-parallel"`),
},
WantDeletes: []clientgotesting.DeleteActionImpl{
{Name: resources.ParallelBranchChannelName(parallelName, 0)},
},
Expand Down
0