8000 fix: e2e scenarion config test errorf format for go 1.24 by gauron99 · Pull Request #2810 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: e2e scenarion config test errorf format for go 1.24 #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

gauron99
Copy link
Contributor
@gauron99 gauron99 commented Apr 24, 2025

e2e scenarion config test errorf format fix

This new format is for go 1.24 which is introduced in the next open deps PR

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@knative-prow knative-prow bot requested review from jrangelramos and vyasgun April 24, 2025 11:44
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2025
@gauron99 gauron99 changed the title e2e scenarion config test errorf format fix fix: e2e scenarion config test errorf format for go 1.24 Apr 24, 2025
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Copy link
knative-prow bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (ace7703) to head (d86eb4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
+ Coverage   61.61%   62.46%   +0.84%     
==========================================
  Files         131      131              
  Lines       15794    15794              
==========================================
+ Hits         9732     9865     +133     
+ Misses       5152     4991     -161     
- Partials      910      938      +28     
Flag Coverage Δ
e2e-test 35.37% <ø> (+0.02%) ⬆️
e2e-test-oncluster 33.82% <ø> (+1.40%) ⬆️
e2e-test-oncluster-runtime 28.16% <ø> (?)
e2e-test-runtime-go 25.73% <ø> (?)
e2e-test-runtime-node 25.09% <ø> (?)
e2e-test-runtime-quarkus 25.17% <ø> (?)
e2e-test-runtime-rust 24.68% <ø> (?)
e2e-test-runtime-springboot 24.72% <ø> (?)
e2e-test-runtime-typescript 25.10% <ø> (?)
integration-tests 48.60% <ø> (+1.78%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot merged commit 69cbc75 into knative:main Apr 24, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0