8000 Stop promoting IPv4 NOW by matejvasek · Pull Request #2899 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop promoting IPv4 NOW #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Stop promoting IPv4 NOW #2899

wants to merge 7 commits into from

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek
feat: py func listen dual-stack
ccee586 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
fix: Go host built image listens on any iface
e8c5342 
Previously it was listening only on localhost

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos June 30, 2025 12:23
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2025
@matejvasek
Stop promoting IPv4 NOW
1d7fdb7 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek force-pushed the stop-promoting-ipv4-now branch from e4315c5 to 1d7fdb7 Compare June 30, 2025 12:24
@matejvasek matejvasek changed the title Stop promoting ipv4 NOW Stop promoting IPv4 NOW Jun 30, 2025
@matejvasek matejvasek marked this pull request as draft June 30, 2025 12:31
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 30, 2025

@matejvasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_func_main 1d7fdb7 link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.52%. Comparing base (56e1b0f) to head (be9630a).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/oci/python_builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
+ Coverage   59.25%   61.52%   +2.27%     
==========================================
  Files         129      129              
  Lines       16246    16311      +65     
==========================================
+ Hits         9626    10035     +409     
+ Misses       5722     5320     -402     
- Partials      898      956      +58
Flag Coverage Δ
e2e-tests 42.35% <62.50%> (+1.33%) ⬆️
integration-tests 48.00% <50.00%> (?)
unit-tests 48.16% <75.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
fixup
5b20522 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2025
@matejvasek
fixup
2284198 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2025
@matejvasek
fixup
d116c01 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2025
@matejvasek
fixup
be9630a 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@lkingland
Copy link
Member

Agreed!
Happy to review as soon as you think this one's ready

@lkingland
Copy link
Member

For Reference:

"Stop promoting IPv4 NOW" (Google Doc)

@matejvasek
Copy link
Contributor Author

@lkingland We actually merged most of this changes under separate PRs, I might close this later.

@matejvasek matejvasek closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @lkingland
0