8000 fix: pass LISTEN_ADDRESS to runner by matejvasek · Pull Request #2901 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pass LISTEN_ADDRESS to runner #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: pass LISTEN_ADDRESS to runner #2901

merged 1 commit into from
Jul 1, 2025

Conversation

matejvasek
Copy link
Contributor
@matejvasek matejvasek commented Jun 30, 2025 •
edited
Loading
  • Local (non-containerized) runner can run on various interfaces/addresses (e.g. [::]:8080, 10.0.0.1:1234).
    Before it worked only on IPv4 loopback (127.0.0.1).
  • Fixed incorrect host port joining (causing a bug with IPv6 addresses).

@matejvasek
fix: pass LISTEN_ADDRESS to runner
6cce86c 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from nainaz and vyasgun June 30, 2025 22:32
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2025
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for nainaz and vyasgun June 30, 2025 22:34
@matejvasek
Copy link
Contributor Author

PTAL @lkingland

@codecov Codecov
Copy link
codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (a93cbe6) to head (6cce86c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
+ Coverage   59.69%   61.51%   +1.81%     
==========================================
  Files         129      129              
  Lines       16311    16310       -1     
==========================================
+ Hits         9737    10033     +296     
+ Misses       5674     5321     -353     
- Partials      900      956      +56
Flag Coverage Δ
e2e-tests 42.35% <100.00%> (+7.94%) ⬆️
integration-tests 47.97% <0.00%> (+1.71%) ⬆️
unit-tests 48.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland
Copy link
Member

/approve
/lgtm

Thanks Matej!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f9bf9fe into knative:main Jul 1, 2025
57 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @lkingland
0