8000 fix: return better error when using pack+python by matejvasek · Pull Request #2904 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: return better error when using pack+python #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: return better error when using pack+python #2904

merged 1 commit into from
Jul 1, 2025

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested review from dsimansk and jrangelramos July 1, 2025 08:49
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
matzew
matzew reviewed Jul 1, 2025
View reviewed changes
@matejvasek
fix: return better error when using pack+python
d5a60ea 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek force-pushed the disable-pack-python branch from dcaa123 to d5a60ea Compare July 1, 2025 08:53
lkingland
lkingland approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member
@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Much better UX

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link
codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.51%. Comparing base (58fb81a) to head (d5a60ea).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
+ Coverage   60.75%   61.51%   +0.75%     
==========================================
  Files         129      129              
  Lines       16327    16330       +3     
==========================================
+ Hits         9920    10045     +125     
+ Misses       5479     5327     -152     
- Partials      928      958      +30
Flag Coverage Δ
e2e-tests 42.39% <0.00%> (+1.39%) ⬆️
integration-tests 47.99% <0.00%> (+1.72%) ⬆️
unit-tests 48.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot merged commit dfe2109 into knative:main Jul 1, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@lkingland lkingland lkingland approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @matzew @lkingland
0