chore: fix build and test tags #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current build tagging system was predicated on the idea that integraion, e2e and unit tests are entirely separate. The correct way to treat these is as inclusive with unit tests. Thus this pr removes the exclusion of unit test from integration tests runs, treating -tags integration as indicating "unit tests plus integration tests".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 60.50% 61.37% +0.87%
==========================================
Files 130 130
Lines 16406 16406
==========================================
+ Hits 9926 10069 +143
+ Misses 5553 5384 -169
- Partials 927 953 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes !integration build tags
The current build tagging system was predicated on the idea that
integraion, e2e and unit tests are entirely separate. The correct way
to treat these is as inclusive with unit tests. Thus this pr removes
the exclusion of unit test from integration tests runs, treating
-tags integrationas indicating "unit tests plus integration tests"./kind cleanup