8000 Update pack dependency by matejvasek · Pull Request #2337 · knative/func · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update pack dependency #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 5, 2024
Merged

Update pack dependency #2337

merged 5 commits into from
Jun 5, 2024

Conversation

matejvasek
Copy link
Contributor
@matejvasek matejvasek commented Jun 4, 2024 •
edited
Loading
  • Updated pack dependency

matejvasek added 2 commits June 4, 2024 07:23
@matejvasek
refactor: extracted function
3b9262f 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
chore: update pack dep
1dbf8e6 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot requested a review from maximilien June 4, 2024 07:41
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@matejvasek matejvasek removed the request for review from maximilien June 4, 2024 07:42
@codecov Codecov
Copy link
codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (aa909bd) to head (e7f3035).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2337      +/-   ##
==========================================
+ Coverage   60.22%   65.79%   +5.56%     
==========================================
  Files         128      128              
  Lines       14890    11532    -3358     
==========================================
- Hits         8968     7587    -1381     
+ Misses       5003     2990    -2013     
- Partials      919      955      +36
Flag Coverage Δ
e2e-test 38.00% <ø> (ø)
e2e-test-oncluster 31.23% <ø> (+0.04%) ⬆️
e2e-test-oncluster-runtime 27.16% <ø> (?)
e2e-test-runtime-node 27.00% <ø> (?)
e2e-test-runtime-python 27.00% <ø> (?)
e2e-test-runtime-quarkus 27.10% <ø> (?)
e2e-test-runtime-rust 26.11% <ø> (?)
e2e-test-runtime-springboot 26.15% <ø> (?)
e2e-test-runtime-typescript 27.09% <ø> (?)
integration-tests 51.37% <ø> (+2.47%) ⬆️
unit-tests 49.29% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @dsimansk @lkingland @gauron99

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
dsimansk
dsimansk reviewed Jun 4, 2024
View reviewed changes
dsimansk
dsimansk reviewed Jun 4, 2024
View reviewed changes
@matejvasek
chore: updated imgutil
a26b366 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
matejvasek added 2 commits June 5, 2024 14:20
@matejvasek
fixup: run hack/update-deps.sh
4cac91e 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
fixup: remote the now unnecessary rename
e7f3035 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @dsimansk @lkingland @gauron99

@matejvasek matejvasek requested review from lkingland and dsimansk June 5, 2024 13:10
@dsimansk
Copy link
Contributor
dsimansk commented Jun 5, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

/ok-to-test

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 5, 2024
@knative-prow knative-prow bot merged commit 0647fc4 into knative:main Jun 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @dsimansk @lkingland
0