8000 use gobwas/ws instead of gorilla/websocket by Gekko0114 · Pull Request #799 · knative/networking · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use gobwas/ws instead of gorilla/websocket #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

use gobwas/ws instead of gorilla/websocket #799

wants to merge 7 commits into from

Conversation

Gekko0114
Copy link
@Gekko0114 Gekko0114 commented Apr 30, 2023 •
edited
Loading

Related to knative/pkg#2730, knative/serving#13932, knative/serving#13824
This code doesn't depend on knative.dev/pkg/websocket. We can complete this PR without considering knative.dev/pkg

Changes

https://github.com/gorilla/websocket is deprecated and unmaintained.
We should switch to something that is and ensure everything works as expected (ie. draining in queue proxy etc).
replaced gorilla/websocket with gobwas/ws

  • 🧹 Update or clean up current behavior

/kind deprecation

Fixes #800

Release Note

/kind deprecation

@knative-prow knative-prow bot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 30, 2023
@knative-prow
Copy link
knative-prow bot commented Apr 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gekko0114
Once this PR has been reviewed and has the lgtm label, please assign kvmware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from mgencur and pradnyavmw April 30, 2023 07:25
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2023
@knative-prow
Copy link
knative-prow bot commented Apr 30, 2023

Welcome @Gekko0114! It looks like this is your first PR to knative/networking 🎉

@knative-prow
Copy link
knative-prow bot commented Apr 30, 2023

Hi @Gekko0114. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gekko0114
Copy link
Author

Hi @dprotaso,

I've created a WIP in the downstream serving repo to test the changes I've made.
Could you have a look?
Thanks,

@nak3 nak3 added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2023
@codecov
Copy link
codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (68725bd) 94.80% compared to head (446232d) 94.80%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files          41       41           
  Lines        1231     1231           
=======================================
  Hits         1167     1167           
  Misses         52       52           
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gekko0114 Gekko0114 changed the title WIP: use gobwas/ws instead of gorilla/websocket use gobwas/ws instead of gorilla/websocket May 1, 2023
@Gekko0114 Gekko0114 changed the title use gobwas/ws instead of gorilla/websocket WIP: use gobwas/ws instead of gorilla/websocket May 1, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2023
@Gekko0114 Gekko0114 changed the title WIP: use gobwas/ws instead of gorilla/websocket use gobwas/ws instead of gorilla/websocket May 1, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

Closing this for now - seems like RedHat might become owners of gorilla/websocket - so we'll pause this for now

knative/serving#13824 (comment)

@dprotaso dprotaso closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@pradnyavmw pradnyavmw Awaiting requested review from pradnyavmw

Assignees
No one assigned
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop use of https://github.com/gorilla/websocket
4 participants
@Gekko0114 @knative-prow-robot @dprotaso @nak3
0