8000 Fix issue 1876 by vaikas · Pull Request #1877 · knative/pkg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issue 1876 #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2020
Merged

Fix issue 1876 #1877

merged 6 commits into from
Oct 30, 2020

Conversation

vaikas
Copy link
Contributor
@vaikas vaikas commented Oct 30, 2020 •
edited
Loading

Signed-off-by: Ville Aikas vaikas@vmware.com

Document the fact that you can induce failures in subresources and add tests for it.

@vaikas
Fix issue 1876
55da1b4 
Signed-off-by: Ville Aikas <vaikas@vmware.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 30, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2020
vaikas added 2 commits October 30, 2020 12:57
@vaikas
fix boilerplate
03e4e46 
Signed-off-by: Ville Aikas <vaikas@vmware.com>
@vaikas
ok bot
04aa906
@codecov
Copy link
codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #1877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files         223      223           
  Lines        9492     9492           
=======================================
  Hits         6583     6583           
  Misses       2576     2576           
  Partials      333      333

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d905b3...d095977. Read the comment docs.

@markusthoemmes
Copy link
Contributor
8000

This should work on the existing InduceFailure since kubernetes/kubernetes@47277f2 (which is part of the 1.18 line).

@vaikas
Copy link
Contributor Author
vaikas commented Oct 30, 2020

Thanks @markusthoemmes :)

vaikas added 2 commits October 30, 2020 13:43
@vaikas
cleanup
99be918
@vaikas
lints
d095977 
Signed-off-by: Ville Aikas <vaikas@vmware.com>
markusthoemmes
markusthoemmes approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor
@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 256ae89 into knative:master Oct 30, 2020
@vaikas vaikas deleted the subresource-failure branch October 30, 2020 13:15
@vaikas vaikas mentioned this pull request Oct 30, 2020
Closed
@vagababov vagababov mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7A68
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@grantr grantr Awaiting requested review from grantr

@tcnghia tcnghia Awaiting requested review from tcnghia

@whaught whaught Awaiting requested review from whaught

Assignees

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaikas @markusthoemmes @knative-prow-robot
0