8000 Update Readme.md by Leask · Pull Request #231 · koajs/session · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Readme.md #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Update Readme.md #231

merged 1 commit into from
Apr 6, 2025

Conversation

Leask
Copy link
Contributor
@Leask Leask commented Mar 27, 2025

Providing nul as sameSite will lead to errors.

Zod requires sameSite to be a string, so the description in the documentation was inaccurate and has been corrected.

ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "sameSite"
    ],
    "message": "Expected string, received null"
  }
]

Checklist

  • [✅] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [✅] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [✅] I have written a commit message that passes commitlint linting.
  • [✅] I have ensured that my code changes pass linting tests.
  • [✅] I have ensured that my code changes pass unit tests.
  • [✅] I have described my pull request and the reasons for code changes along with context if necessary.

Providing `nul` as `sameSite` will lead to errors.

```
ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "sameSite"
    ],
    "message": "Expected string, received null"
  }
]
```
@jonathanong jonathanong merged commit 968ae94 into koajs:master Apr 6, 2025
14 checks passed
@Leask
Copy link
Contributor Author
Leask commented Apr 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0