-
Notifications
You must be signed in to change notification settings - Fork 48
✨ Initial draft to add cross platform supported grep go package #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shawn-hurley
wants to merge
12
commits into
konveyor:main
Choose a base branch
from
shawn-hurley:kthatipally/add-grep-regex2-go-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✨ Initial draft to add cross platform supported grep go package #810
shawn-hurley
wants to merge
12
commits into
konveyor:main
from
shawn-hurley:kthatipally/add-grep-regex2-go-package
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
411e1ec
to
9c7e21b
Compare
shawn-hurley
commented
Apr 5, 2025
shawn-hurley
commented
Apr 5, 2025
a1b31d0
to
d218269
Compare
This was referenced Apr 14, 2025
2605a9a
to
cc8cf27
Compare
Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
* Fixing dockerfile to make running tests locally work * Fixing container settings for new gopls location * Fixing rule-example to because of the inclusion test was getting incorrect results * Fixing engine.go so that rule id is in logger for info rules Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shurley@hurley.page> Signed-off-by: Shawn Hurley <shawn@hurley.page>
e85f346
to
619167c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the implementation to fix up some of the things about matching on files earlier and to add a chunk reader so that we can more quickly determine if we need to read the file line by line while not worried about bring GB's into memory.
Signed-off-by: Shawn Hurley shurley@hurley.page