8000 :bug: Reduce noise produced by the builtin provider. by jortel · Pull Request #781 · konveyor/tackle2-hub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Reduce noise produced by the builtin provider. #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

jortel
Copy link
Contributor
@jortel jortel commented Feb 6, 2025

When auth is enabled, the builtin provider is logging all errors (even token not authenticated). Not authenticating the token is is part of the designed process. The builtin provider should only log invalid tokens and a higher (level=2) logging level. Tokens not authenticated should only be logged (level=1) when none of the providers can authenticate it.

Spam Example:

time=2025-02-06T14:33:58Z level=info msg=[auth] Token
 [eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJHb1ZGZ3ltY2pCT3Z2eDNtLUFy
CB0YXJnZXRzOmdldCB0YXJnZXRzOnBvc3QgdHJhY2tlcnM6cG9zdCBhcHBsaWNhdGlv
ZXJzOmRlbGV0ZSBzdGFrZWhvbGRlcnM6cG9zdCBwcm9maWxlIGJ1Y2tldHM6ZGVsZXR
XGJEv_63_gL3RezVKBOMI4G_pVXzsNgzSB-aK703RVwfVxZrys2I3z7tA4u2LynMVFTuZ] not-authenticated.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel force-pushed the reduce-builtin-provider-logging branch from 87e7cb0 to 23f51e4 Compare February 26, 2025 13:00
Copy link
Member
@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0