Fix typehints #47
Merged
Fix typehints #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test coverage of c6dfed5: 94% |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the type hint for the digest property in repype/task.py to reflect that the method can now return None.
- Updated the return type of the digest property from Mapping[str, Any] to Optional[Mapping[str, Any]]
- Revised the relevant type hints to match the updated functionality
Comments suppressed due to low confidence (1)
repype/task.py:241
- The updated Optional return type indicates that digest may now return None. Ensure that all users of this property are updated to handle this nullability to maintain API consistency.
def digest(self) -> Optional[Mapping[str, Any]]:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.