8000 Prototype new animator, supporting attaching new nodes on the fly by soywiz · Pull Request #1095 · korlibs/korge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prototype new animator, supporting attaching new nodes on the fly #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 10, 2022
Merged

Prototype new animator, supporting attaching new nodes on the fly #1095

merged 18 commits into from
Nov 10, 2022

Conversation

soywiz
Copy link
Collaborator
@soywiz soywiz commented Nov 7, 2022

No description provided.

@codecov-commenter
Copy link
codecov-commenter commented Nov 7, 2022 •
edited
Loading

Codecov Report

Base: 52.77% // Head: 53.31% // Increases project coverage by +0.53% 🎉

Coverage data is based on head (3c232eb) compared to base (720b5ff).
Patch coverage: 64.10% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   52.77%   53.31%   +0.53%     
==========================================
  Files        1856     1851       -5     
  Lines      121475   120545     -930     
  Branches    19023    18778     -245     
==========================================
+ Hits        64103    64263     +160     
+ Misses      52075    50980    -1095     
- Partials     5297     5302       +5
Flag Coverage Δ
unittests 53.31% <64.10%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/commonMain/kotlin/com/soywiz/klock/RangesExt.kt 0.00% <0.00%> (ø)
...ox/src/commonMain/kotlin/samples/MainAnimations.kt 0.00% <0.00%> (ø)
...ndbox/src/commonMain/kotlin/samples/MainFilters.kt 0.00% <0.00%> (ø)
...src/commonMain/kotlin/samples/MainFiltersSample.kt 0.00% <0.00%> (ø)
...sandbox/src/commonMain/kotlin/samples/MainMasks.kt 0.00% <ø> (ø)
...box/src/commonMain/kotlin/samples/connect4/main.kt 0.00% <0.00%> (ø)
...ge/src/commonMain/kotlin/com/soywiz/korge/Korge.kt 39.61% <0.00%> (-0.12%) ⬇️
...nMain/kotlin/com/soywiz/korge/baseview/BaseView.kt 52.94% <0.00%> (-0.64%) ⬇️
...ain/kotlin/com/soywiz/korge/component/Component.kt 40.38% <0.00%> (+1.16%) ⬆️
...ommonMain/kotlin/com/soywiz/korge/lipsync/Voice.kt 0.00% <0.00%> (ø)
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobe-m
Copy link
Member
jobe-m commented Nov 8, 2022

Is there an example to check/learn how this works? :)

@soywiz
Copy link
Collaborator Author
soywiz commented Nov 8, 2022

@jobe-m https://github.com/korlibs/korge-mascots/tree/main/example

soywiz added 17 commits November 8, 2022 17:54
@soywiz
Some fixes
a363a2c
@soywiz
Change default local version to 999.0.0.999
cade74a
@soywiz
Do not require V2 to call .init() explicitly
024091b
@soywiz
Add V2.incr variants for delta changes
39c04d5
@soywiz
Update NewAnimator with fixes and improvements
57582d4
@soywiz
Minor Klock additions
9f43ee5
@soywiz
Much more work on NewAnimator + tests
6ce0649
@soywiz
Add test checking V2 reusal when initial was not set
c01f624
@soywiz
Fixes KMutableProperty0.incr when reusing V2 instance
0decd08
@soywiz
Some fixes, remove old animator and replace with the new animator
bbac665
@soywiz
Update remaining versions to 999.0.0.999
d581b6e
@soywiz
Try to avoid overload issue that was not detected in the editor
f3d7f39
@soywiz
Fix test not working properly on JS due to double.toString inconsistency
c1b2be3
@soywiz
Added TimeSpan.isNil
5d409f2
@soywiz
Optimize KMutableProperty0.incr
f803115
@soywiz
Fixes FastArrayList indexOf null on non-JS targets and contains on K/…
6516da3 
…N targets that use indexOf internally
@soywiz
Some cleanups and extra verifications
3c232eb
@soywiz soywiz merged commit 5943042 into main Nov 10, 2022
@soywiz soywiz deleted the feature/NewAnimator branch October 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soywiz @codecov-commenter @jobe-m
0