8000 [#363] Use `generic-data` instead of `generic-deriving` by chshersh · Pull Request #406 · kowainik/summoner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#363] Use generic-data instead of generic-deriving #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2020
Merged

[#363] Use generic-data instead of generic-deriving #406

merged 2 commits into from
Feb 19, 2020

Conversation

chshersh
Copy link
Contributor

Resolves #363

That was quite painless 🙂

@chshersh chshersh added this to the v2.0: Major update milestone Feb 19, 2020
@chshersh chshersh requested a review from vrom911 as a code owner February 19, 2020 19:33
@chshersh chshersh self-assigned this Feb 19, 2020
hint-man[bot]
hint-man bot approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor
@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@chshersh chshersh force-pushed the chshersh/363-Use-generic-data-instead-of-generic-deriving branch from b5c59f6 to 989400e Compare February 19, 2020 19:39
@chshersh chshersh force-pushed the chshersh/363-Use-generic-data-instead-of-generic-deriving branch from 989400e to 1f929b5 Compare February 19, 2020 19:40
vrom911
vrom911 approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member
@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'a nice! 👍

@vrom911 vrom911 merged commit 1954789 into master Feb 19, 2020
@vrom911 vrom911 deleted the chshersh/363-Use-generic-data-instead-of-generic-deriving branch February 19, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@hint-man hint-man[bot] hint-man[bot] approved these changes

Assignees

@chshersh chshersh

Labels
library refactoring
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging this pull request may close these issues.

Use generic-data instead of generic-deriving
2 participants
@chshersh @vrom911
0