[#114] Add non-interactive mode for summoner
#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
523bb1c to
6beac3a
Compare
chshersh
reviewed
Feb 23, 2020
Comment on lines
+469
to
+473
| libraryP d = flag Idk d $ mconcat | ||
| [ long "library" | ||
| , short 'l' | ||
| , help "Library folder" | ||
| ] |
There was a problem hiding this comment.
Nice refactoring with CLI options!
Comment on lines
+18
to
+28
| -- | Switcher for non-interactive mode. | ||
| data Interactivity | ||
| = Interactive | ||
| | NonInteractive | ||
| deriving stock (Show, Eq) | ||
|
|
||
| -- | Is interactivity mode 'NonInteractive'? | ||
| isNonInteractive :: Interactivity -> Bool | ||
| isNonInteractive = \case | ||
| NonInteractive -> True | ||
| Interactive -> False |
There was a problem hiding this comment.
I already like this module 😍 Nice idea to use enums instead of booleans 👍
| could be. | ||
| -} | ||
|
|
||
| module Summoner.Mode |
There was a problem hiding this comment.
Let's also reexport this module from Summoner.hs
summoner-tui/src/Summoner/Tui.hs
Outdated
Comment on lines
309
to
314
| year <- currentYear | ||
| guessConfig <- guessConfigFromGit | ||
| lc <- fetchLicenseCustom | ||
| licenseName | ||
| (fromMaybe "YOUR NAME" $ getLast $ cFullName guessConfig) | ||
| year |
There was a problem hiding this comment.
I think these lines can be moved into a separate function that returns IO License. And then you can reuse them in both CLI and TUI files.
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #114