-
-
Notifications
You must be signed in to change notification settings - Fork 39
Prepare for 0.5.0 release #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -69,8 +69,7 @@ The change log is available [on GitHub][2]. | |||
* [#58](https://github.com/kowainik/tomland/issues/58): | |||
Add `decodeFile` function. | |||
|
|||
0.3 | |||
===== | |||
## 0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## 0.3 | |
## 0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually 0.3
on Hackage (for some unknown reason):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a tragedy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor, and I don't know why GitHub won't let me comment on that line, but I think two empty lines (line 88 and 92, above "_Migration guide") make the section 0.3 look different than the other sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiegillet Yeah, in GitHub you can comment only to diff lines or some near lines (which is quite sad, because sometimes people might not be aware of some distant code.
Regarding empty lines: this is needed for showing Migration guide
on separate line. See the rendered CHANGELOG. I've just discussed with @vrom911 how we want to show breaking changes. Will do this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is because the rendered file should show it on the new line, and we need to add extra newlines for that in markdown.
But good point, thank for paying attention to such details! 👍
f79b753
to
c48048e
Compare
@chshersh I closed benchmark issues and forgot to mention it in changelog. Could you write it in, please? |
@@ -69,8 +69,7 @@ The change log is available [on GitHub][2]. | |||
* [#58](https://github.com/kowainik/tomland/issues/58): | |||
Add `decodeFile` function. | |||
|
|||
0.3 | |||
===== | |||
## 0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is because the rendered file should show it on the new line, and we need to add extra newlines for that in markdown.
But good point, thank for paying attention to such details! 👍
Let me know if I missed something.