8000 Prepare for 0.5.0 release by chshersh · Pull Request #138 · kowainik/tomland · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepare for 0.5.0 release #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Prepare for 0.5.0 release #138

merged 2 commits into from
Nov 12, 2018

Conversation

chshersh
Copy link
Contributor

Let me know if I missed something.

@chshersh chshersh added the doc Library documentation (Hackage, tutorials, etc.) label Nov 12, 2018
@chshersh chshersh added this to the v1.0.0: Public release milestone Nov 12, 2018
8000
@chshersh chshersh self-assigned this Nov 12, 2018
@@ -69,8 +69,7 @@ The change log is available [on GitHub][2].
* [#58](https://github.com/kowainik/tomland/issues/58):
Add `decodeFile` function.

0.3
=====
## 0.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.3
## 0.3.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually 0.3 on Hackage (for some unknown reason):

8000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a tragedy!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor, and I don't know why GitHub won't let me comment on that line, but I think two empty lines (line 88 and 92, above "_Migration guide") make the section 0.3 look different than the other sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiegillet Yeah, in GitHub you can comment only to diff lines or some near lines (which is quite sad, because sometimes people might not be aware of some distant code.

Regarding empty lines: this is needed for showing Migration guide on separate line. See the rendered CHANGELOG. I've just discussed with @vrom911 how we want to show breaking changes. Will do this now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because the rendered file should show it on the new line, and we need to add extra newlines for that in markdown.
But good point, thank for paying attention to such details! 👍

@chshersh chshersh force-pushed the chshersh/release-0.5.0 branch from f79b753 to c48048e Compare November 12, 2018 12:06
@willbasky
Copy link
Collaborator

@chshersh I closed benchmark issues and forgot to mention it in changelog. Could you write it in, please?

@chshersh
Copy link
Contributor Author

@@ -69,8 +69,7 @@ The change log is available [on GitHub][2].
* [#58](https://github.com/kowainik/tomland/issues/58):
Add `decodeFile` function.

0.3
=====
## 0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because the rendered file should show it on the new line, and we need to add extra newlines for that in markdown.
But good point, thank for paying attention to such details! 👍

@vrom911 vrom911 merged commit 6f47c3d into master Nov 12, 2018
@vrom911 vrom911 deleted the chshersh/release-0.5.0 branch November 12, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Library documentation (Hackage, tutorials, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0