Changes to create new wrapper around new Neo4J HTTP API #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created new packages to separate utility classes, errors, etc. for further use in transaction package - creation of transaction package - added methods for adding nodes in Neo4J 4.X or later using new HTTP API with transactions Remaining things TODO: - add unit tests for new api - fix unit test failures - documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As of Neo4J 4.x, the Neo4J HTTP API was updated to support transactions and the old REST API was deprecated. However, existing customers as well as users who may want to leverage services as Neo4J Aura may still need to leverage the old REST base API based on nodes, relationships, etc. Therefore, the set of changes here are a series of refactorings I propose as part of a new effort to support the transaction based HTTP API from within cl-neo4j.
Specifically, these changes include:
for further use in transaction package
Remaining things TODO:
There is still some work to get done before this is fully polished, but given the set of changes made involved some significant refactoring, I thought I'd create a pull-request to get some feedback.