fix: remove the use of findDOMNode #471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace ReactDOM.findDOMNode with React.createRef() for React 16.3+ compatibility - Add fallback to callback refs for older React versions - Make implementation backward compatible to support all React versions - Update flow types to fix typechecking errors - Keep minimal findDOMNode fallback only for test environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the use of
findDOMNodeand by this allowing zoid to be used with React 19 (fixed #396)React minimum version is now 16.3
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-reactdom-finddomnode