8000 fix(ui): Fix squashed loading indicator by lingyicute · Pull Request #1937 · krille-chan/fluffychat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ui): Fix squashed loading indicator #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): Fix squashed loading indicator #1937

wants to merge 1 commit into from
+34 −20

Conversation

lingyicute
Copy link

The loading animation in ChatBackup Bootstrap dialog was appearing squashed/elliptical when the dialog first opened. This was caused by the CircularProgressIndicator being placed directly in a Column with CrossAxisAlignment.stretch.

This commit:

  • Wraps the CircularProgressIndicator in a fixed-size (50x50) SizedBox
  • Centers UI elements using Center widget
  • Changes the main layout's crossAxisAlignment from stretch to center
  • Standardizes UI across loading, error, and completion states
  • Adds appropriate width constraints to buttons

This is a visual-only change that improves UX without affecting functionality.

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

@lingyicute
fix(ui): Fix squashed loading indicator
428b735 
The loading animation in ChatBackup Bootstrap dialog was appearing squashed/elliptical
when the dialog first opened. This was caused by the CircularProgressIndicator being
placed directly in a Column with CrossAxisAlignment.stretch.

This commit:
- Wraps the CircularProgressIndicator in a fixed-size (50x50) SizedBox
- Centers UI elements using Center widget
- Changes the main layout's crossAxisAlignment from stretch to center
- Standardizes UI across loading, error, and completion states
- Adds appropriate width constraints to buttons

This is a visual-only change that improves UX without affecting functionality.
@lingyicute lingyicute requested a review from krille-chan as a code owner June 3, 2025 09:51
@lingyicute
Copy link
Author

By the way: I maintain a privately modified fork of FluffyChat at lingyicute/Yomi-Android, where I've fixed numerous minor bugs during development. I will attempt to isolate these changes into separate commits and strive to contribute all fixes back to the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krille-chan krille-chan Awaiting requested review from krille-chan krille-chan is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lingyicute
0