8000 Weblate conflict by lucasmz-dev · Pull Request #1971 · krille-chan/fluffychat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Weblate conflict #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

Weblate conflict #1971

merged 4 commits into from
Jun 23, 2025

Conversation

lucasmz-dev
Copy link
Contributor
@lucasmz-dev lucasmz-dev commented Jun 19, 2025

I modified a few English strings, simple things, but this seems to have triggered Weblate to completely go and force-write every translation file, in the end, a conflict happened, and it was hard to analyze what was changed or not.

It seems like at some point, the files got rewritten with a different setup than Weblate usually uses, it doesn't do anything initially, but ends up resulting in things like this sometimes.

There are two commits relevant to the file formatting, fixing indentation and missing newlines, this makes the files the same as Weblate ends up rewriting, so it should prevent this in the future.
Then, the relevant commits were cherry-picked. There were only changes in Estonian and pt-BR. I just proofread pt-BR so a simple reset would be quite sad :D

To merge this, simply merge it (preferably don't squash) and reset the repository in Weblate, and that should work.

@lucasmz-dev lucasmz-dev marked this pull request as draft June 19, 2025 05:58
@lucasmz-dev lucasmz-dev force-pushed the weblate-conflict branch 2 times, most recently from 360d01a to 84f0d65 Compare June 19, 2025 06:35
@lucasmz-dev
Copy link
Contributor Author

If it is desired to block editing English strings, or letting Weblate end up mutating them, then disable 'Edit base file' in the "Translations" component inside the Translation settings sub-menu for that component.

@lucasmz-dev lucasmz-dev marked this pull request as ready for review June 19, 2025 06:41
@lucasmz-dev
Copy link
Contributor Author

I noticed some empty @: {}, so just empty stuff that Weblate seems to add.
I also noticed that you never seemed to play with the add-ons, https://hosted.weblate.org/changes/browse/fluffychat/translations/?action=61&action=60&action=62&user=&exclude_user=&period=
That might be the issue, there are add-ons that solve common issues like this, like cleanup empty strings.

@lucasmz-dev
Copy link
Contributor Author

I'm not familiar with the format here ofc! I mess more with Android, but still, worth looking into
Also sorry if you did, nothing shows up in history though at least

lucasmz-dev and others added 4 commits June 21, 2025 13:08
weblate otherwise will reformat all of these anyway
weblate will otherwise add these anyway, which can cause commit spam
Currently translated at 99.8% (777 of 778 strings)

Translation: FluffyChat/Translations
Translate-URL: https://hosted.weblate.org/projects/fluffychat/translations/et/
Currently translated at 98.8% (769 of 778 strings)

Translation: FluffyChat/Translations
Translate-URL: https://hosted.weblate.org/projects/fluffychat/translations/pt_BR/
@lucasmz-dev
Copy link
Contributor Author

@krille-chan can you get a quick look of this? I wanna take advantage of my want to go messing with pt-BR in Weblate

@krille-chan
Copy link
Owner

Okay thank you. I'll try it out :)

@krille-chan krille-chan merged commit a791f63 into krille-chan:main Jun 23, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0