8000 feat: improvements to sync snapshot script by kangsorang · Pull Request #53 · kroma-network/kroma-up · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: improvements to sync snapshot script #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: improvements to sync snapshot script #53

wants to merge 1 commit into from

Conversation

kangsorang
Copy link
Contributor

Description

Speed and stability improvements to snapshot script

  • improved the speed of make snapshot, sync sync using aria2c, pigz libraries.
  • increased reliability by using docker inspect for result lookup for docker execution requests.

sm-stack
sm-stack reviewed Jan 6, 2025
View reviewed changes
@kangsorang kangsorang force-pushed the feat/update-sync-script branch 2 times, most recently from f040112 to 7c24052 Compare January 6, 2025 07:21
seolaoh
seolaoh reviewed Jan 6, 2025
View reviewed changes
@seolaoh
Copy link
Contributor
seolaoh commented Jan 6, 2025

I hope you to test this script when Sepolia hardfork completed. Thanks!
8000

@kangsorang
feat: modify the sync snapshot script
1d50dc7 
- improved the speed of make snapshot, sync sync using aria2c, pigz libraries.
- increased reliability by using docker inspect for result lookup for docker execution requests.
@kangsorang kangsorang force-pushed the feat/update-sync-script branch from 7c24052 to 1d50dc7 Compare January 6, 2025 08:55
@kangsorang
Copy link
Contributor Author

I hope you to test this script when Sepolia hardfork completed. Thanks!

Tested with holesky, will check after sepolia hardfork.

@kangsorang
Copy link
Contributor Author
kangsorang commented Jan 10, 2025 •
edited
Loading

Here's what I found out later.
There is a difference in the structure of docker usage in devops-kroma-up and kroma-up.

  • devops-kroma-up: mount to host directory and use it
  • kroma-up : uses docker volume

So we can't use the same scheme as devops-kroma-up (dealing directly with the .kroma directory on host).
I'll take this into consideration. Do not merge before then.

@kangsorang kangsorang marked this pull request as draft February 3, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pangssu Pangssu Pangssu approved these changes

@seolaoh seolaoh seolaoh approved these changes

@sm-stack sm-stack sm-stack approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangsorang @seolaoh @Pangssu @sm-stack
0