fix overflow n_reads in show_progress_until_done #265
Conversation
|
Oh, good point! I’d be happy to merge this as-is, but would you perhaps be interested in fixing |
|
Thank you for your comment. |
|
Changes have been made and corrections made where necessary. Could you please review it? |
src/aln.hpp
Outdated
| unsigned int tot_all_tried = 0; | ||
| unsigned int did_not_fit = 0; | ||
| unsigned int tried_rescue = 0; | ||
| size_t n_reads = 0; |
There was a problem hiding this comment.
I don’t think size_t is the appropriate type here. It is used to represent the size of an object, so it’s used for array indices etc. While it works here because size_t happens to be an unsigned long on the platforms we care about, size_t it is only required to be at least 16 bits, so it could overflow on another platform. I would prefer using a type that does not depend on the platform, so in this case an uint64_t.
The strobealign code is not very consistent, yet, in using these explicitly-sized types, sorry for the confusion.
There was a problem hiding this comment.
Thanks for the review.
You are indeed correct. I have fix it.
|
Thanks! I’m sure this is fine with @ksahlin, so I’ll merge this now. |
fix overflow n_reads in show_progress_until_done
Hi.
I was running Strobealign on a large file and noticed that it overflows when the number of reads exceeds the int limit.
n_reads are type inferred as signed int, but here it is better to use size_t.
I fixed this and would appreciate it if you could merge it.