10000 Add inferenceservice finalizer rbac rules by pvaneck · Pull Request #1134 · kserve/kserve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add inferenceservice finalizer rbac rules #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add inferenceservice finalizer rbac rules #1134

merged 1 commit into from
Oct 14, 2020

Conversation

pvaneck
Copy link
Member
@pvaneck pvaneck commented Oct 14, 2020

What this PR does / why we need it:
This is an additional change needed for Openshift clusters. With Kfserving 0.4, I get the same issue mentioned in #1035 even with the changes made in #1122 . Seems like one more finalizer needed permission as adding the line in this PR allowed successful InferenceService creation.

Which issue(s) this PR fixes :
Fixes #1035

Release note:

Add inferenceservices/finalizers RBAC rules to fix failing InferenceService creation

@kubeflow-bot
Copy link

This change is Reviewable

animeshsingh
animeshsingh approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member
@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Tomcli
Copy link
Member
Tomcli commented Oct 14, 2020

/lgtm

@pugangxa
Copy link
Contributor

I think the file is generated, so please add kubebuilder annotation as in PR #1122 if needed.

@pvaneck
Add inferenceservice finalizer rbac rules
46d697c 
This is an additional change needed for Openshift clusters.
@pvaneck pvaneck force-pushed the openshift-finalizer-rbac branch from 116b0da to 46d697c Compare October 14, 2020 05:25
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 14, 2020
@pvaneck
Copy link
Member Author
pvaneck commented Oct 14, 2020

@pugangxa Updated the kubebuilder annotations to reflect the change.

@yuzisun
Copy link
Member
yuzisun commented Oct 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member
yuzisun commented Oct 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit cc35c5f into kserve:master Oct 14, 2020
pvaneck added a commit to pvaneck/kserve that referenced this pull request Oct 14, 2020
@pvaneck
Add inferenceservice finalizer rbac rules (kserve#1134)
baf4ad3 
This is an additional change needed for Openshift clusters.
@pvaneck pvaneck mentioned this pull request Oct 14, 2020
Merged
pvaneck added a commit to pvaneck/kserve that referenced this pull request Oct 16, 2020
@pvaneck
Add inferenceservice finalizer rbac rules (kserve#1134)
444504a 
This is an additional change needed for Openshift clusters.
k8s-ci-robot pushed a commit that referenced this pull request Oct 16, 2020
@pvaneck @pugangxa
Cherry-pick of OpenShift fixes (#1122 and #1134) to release-0.4 (#1136)
f16a9ce 
* Fixed issues on openshift (#1122)

- change to use port 9443
- add rbac for finalizer

* Add inferenceservice finalizer rbac rules (#1134)

This is an additional change needed for Openshift clusters.

Co-authored-by: Gang Pu <pugangxa@cn.ibm.com>
@animeshsingh animeshsingh mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh animeshsingh approved these changes

@pugangxa pugangxa Awaiting requested review from pugangxa

@Tomcli Tomcli Awaiting requested review from Tomcli

Assignees

@animeshsingh animeshsingh

@yuzisun yuzisun

@Tomcli Tomcli

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to create inferenceservice successfully on openshift
7 participants
@pvaneck @kubeflow-bot @Tomcli @pugangxa @yuzisun @k8s-ci-robot @animeshsingh
0