release: v0.8.0-rc0 #1989
Merged
release: v0.8.0-rc0 #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00de7a5 to
2d44d22
Compare
|
/retest |
yuzisun
reviewed
Jan 16, 2022
hack/generate-install.sh
Outdated
| @@ -52,4 +52,6 @@ KUBEFLOW_INSTALL_PATH=$INSTALL_DIR/kserve_kubeflow.yaml | |||
|
|
|||
| mkdir -p $INSTALL_DIR | |||
| kustomize build config/default | sed s/:latest/:$TAG/ > $INSTALL_PATH | |||
| kustomize build config/runtimes >> $INSTALL_PATH | |||
There was a problem hiding this comment.
Suggested change
| kustomize build config/runtimes >> $INSTALL_PATH | |
| kustomize build config/runtimes | sed s/:latest/:$TAG/ >> $INSTALL_PATH |
yuzisun
reviewed
Jan 16, 2022
hack/generate-install.sh
Outdated
| kustomize build config/overlays/kubeflow | sed s/:latest/:$TAG/ > $KUBEFLOW_INSTALL_PATH | ||
| kustomize build config/runtimes >> $KUBEFLOW_INSTALL_PATH |
There was a problem hiding this comment.
Suggested change
| kustomize build config/runtimes >> $KUBEFLOW_INSTALL_PATH | |
| kustomize build config/runtimes | sed s/:latest/:$TAG/ >> $KUBEFLOW_INSTALL_PATH |
0c49cbf to
c16f0ee
Compare
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
c16f0ee to
eea2d02
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jan 16, 2022
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Jan 18, 2022
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):related to #1906
Special notes for your reviewer:
Release note: