8000 Start uvicorn server in multiple process as per worker count by Suresh-Nakkeran · Pull Request #2573 · kserve/kserve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Start uvicorn server in multiple process as per worker count #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 24, 2022
Merged

Start uvicorn server in multiple process as per worker count #2573

merged 13 commits into from
Dec 24, 2022

Conversation

Suresh-Nakkeran
Copy link
Contributor
@Suresh-Nakkeran Suresh-Nakkeran commented Nov 29, 2022 •
edited by yuzisun
Loading

Signed-off-by: Suresh Nakkeran suresh.n@ideas2it.com

  • honor —workers argument to be backwards compatible with previous tornado implementation
  • Fix x-request-id http header as it is case insensitive
  • Improve custom transformer and predictor to handle v2 protocol

@yuzisun yuzisun force-pushed the improvement/multi-processing branch 3 times, most recently from 577bb59 to 2828ef3 Compare December 20, 2022 13:47
Suresh-Nakkeran and others added 4 commits December 21, 2022 22:11
@Suresh-Nakkeran @yuzisun
start uvicorn server in multiple process as per worker count
c51ccdc 
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
@yuzisun
Add status code check for curl tests
96ad7ac 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Remove github token env
47ccc20 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Add istio logs
d35a1c1 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun yuzisun force-pushed the improvement/multi-processing branch from 2828ef3 to d35a1c1 Compare December 22, 2022 03:14
@yuzisun
Enable istio access log
0db0730 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
print full logs
d48bcdc 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Set socket.SO_REUSEADDR
e7549c9 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Fix mem limit
d967558 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Enable grpc
d3b6bd9 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun yuzisun force-pushed the improvement/multi-processing branch from c8bc805 to 34bfda0 Compare December 24, 2022 04:22
@yuzisun
fix custom predictor/transformer examples
d4af39d 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun yuzisun force-pushed the improvement/multi-processing branch 2 times, most recently from 8598464 to c5d2d5d Compare December 24, 2022 19:11
@yuzisun
Handle predictor call errors
2ab2f13 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun yuzisun force-pushed the improvement/multi-processing branch from c5d2d5d to 2ab2f13 Compare December 24, 2022 19:12
@yuzisun yuzisun changed the title [WIP] start uvicorn server in multiple process as per worker count Start uvicorn server in multiple process as per worker count Dec 24, 2022
@yuzisun
Copy link
Member
yuzisun commented Dec 24, 2022

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Suresh-Nakkeran, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 47305d2 into kserve:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexagriffith alexagriffith Awaiting requested review from alexagriffith

@sukumargaonkar sukumargaonkar Awaiting requested review from sukumargaonkar

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suresh-Nakkeran @yuzisun @kserve-oss-bot
0