8000 chore: Free up disk space on E2E test GHA runner node by ckadner · Pull Request #2972 · kserve/kserve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Free up disk space on E2E test GHA runner node #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 16, 2023
Merged

chore: Free up disk space on E2E test GHA runner node #2972

merged 15 commits into from
Jun 16, 2023

Conversation

ckadner
Copy link
Member
@ckadner ckadner commented Jun 6, 2023 •
edited
Loading

Motivation

Some end-to-end tests cannot be run using GitHub Actions due to limited disk space.

We can free up disk space by following some best practices to reduce disk usage for GitHub action runners by deleting binaries that are not needed.

sudo rm -rf /usr/share/dotnet
sudo rm -rf /opt/ghc
sudo rm -rf "/usr/local/share/boost"
sudo rm -rf "$AGENT_TOOLSDIRECTORY"

Modifications

      - name: Free up disk space
        run: |
          # remove non-essential tools and libraries
          sudo rm -rf /opt/ghc
          sudo rm -rf /usr/share/dotnet
          sudo rm -rf /usr/local/share/boost

          # delete libraries for Android (12G), CodeQL (5.3G), PowerShell (1.3G), Swift (1.7G)
          sudo rm -rf /usr/local/lib/android
          sudo rm -rf "${AGENT_TOOLSDIRECTORY}/CodeQL"
          sudo rm -rf /usr/local/share/powershell
          sudo rm -rf /usr/share/swift

Result

Increased available disk space by 21 GB (plus 1 GB after pruning docker images).

Resolves #2950

@ckadner
Remove unnecessary tools and libraries
3be7a90 
Resolves kserve#2950

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested a review from yuzisun June 6, 2023 01:19
@ckadner ckadner self-assigned this Jun 6, 2023
@kserve-oss-bot kserve-oss-bot requested a review from adriangonz June 6, 2023 01:19
@ckadner ckadner marked this pull request as draft June 6, 2023 01:19
ckadner added 12 commits June 5, 2023 18:50
@ckadner
Specify shell
f6a48c3 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Temporarily not prune docker images
be406fd 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Prune docker images
8c614ac 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Update poetry version
6881426 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Setup Minikube before Python
af41f10 
So the disk clean-up of the "$AGENT_TOOLSDIRECTORY"
happens before installing Python 3.9:

>> Requirement already satisfied: poetry<2.0.0,>=1.2.2 in /opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages (from poetry-version-plugin==0.1.4) (1.4.0)

If disk clean-up happens after installing Python:

>> Installing Poetry Version Plugin
   Defaulting to user installation because normal site-packages is not writeable
>> Requirement already satisfied: poetry<2.0.0,>=1.2.2 in /home/runner/.local/lib/python3.10/site-packages (from poetry-version-plugin==0.1.4) (1.4.0)

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Keep "$AGENT_TOOLSDIRECTORY" to keep Python 3.9
904e8c2 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Back to poetry 1.4.0
99ae906 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Increase time limit on slow E2E test
add9edb 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Remove CodeQL
a637d14 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Reenable skipped tests
3b800f0 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Increase timeout for slow E2E tests
bbc398b 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Reinstate skipping the un-skipped tests
4393fd5 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner marked this pull request as ready for review June 9, 2023 16:19
@ckadner
Copy link
Member Author
ckadner commented Jun 9, 2023 •
edited
Loading

@yuzisun -- this PR is ready for review now. Its sole focus is on providing more storage on the GitHub Action runners for E2E tests. I added the disk clean-up step into the Minikube setup action, assuming where ever Minikube is being used, more disk space is need.

I tried to re-enable the Triton (and other skipped) tests, but I assume more setup is needed for those which is best tackled in a separate PR by someone more familiar with the test setup.

yuzisun added 2 commits June 12, 2023 15:38
@yuzisun
Merge branch 'master' into free_up_disk_space_on_E2E_test_runner
4133d11 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Fix the merge
dfec409 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Copy link
Member
yuzisun commented Jun 12, 2023

@ckadner I fixed a merge conflict, can you check if I did correctly?

@ckadner
Copy link
Member Author
ckadner commented Jun 12, 2023

@ckadner I fixed a merge conflict, can you check if I did correctly?

Looks good @yuzisun -- Thanks!

@simondeziel simondeziel mentioned this pull request Jun 15, 2023
Merged
@yuzisun
Copy link
Member
yuzisun commented Jun 16, 2023

Thanks @ckadner for fixing the disk spaces!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 3031694 into kserve:master Jun 16, 2023
@ckadner ckadner mentioned this pull request Jul 25, 2023
Merged
8 tasks
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
@ckadner @yuzisun @Iamlovingit
chore: Free up disk space on E2E test GHA runner node (kserve#2972)
a56d780 
Remove cached tools and unnecessary libraries from GitHub Action
Runner node before setting up Minikube

Resolves kserve#2950

---------

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun Awaiting requested review from yuzisun

@adriangonz adriangonz Awaiting requested review from adriangonz

Assignees

@yuzisun yuzisun

@ckadner ckadner

Labels
approved area/testing lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need larger github action node to run triton test
3 participants
@ckadner @yuzisun @kserve-oss-bot
0