8000 chore: Rename ModelMesh validating webhook by ckadner · Pull Request #3064 · kserve/kserve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Rename ModelMesh validating webhook #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ckadner
Copy link
Member
@ckadner ckadner commented Aug 4, 2023

What this PR does / why we need it:

Required for #3031 to resolve naming conflict.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #3063

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

FYI @Jooho @sivanantha321

Resolves kserve#3063

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested review from sivanantha321 and yuzisun and removed request for adriangonz and Iamlovingit August 4, 2023 18:12
Copy link
Member
@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 1466160 into kserve:master Aug 4, 2023
yuzisun added a commit that referenced this pull request Aug 7, 2023
* Fix configmap docs removed by kustomize build (#3024)

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Loosen ray version range (#2993)

* Loosen ray range

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

* Fix import of RayServeHandle

ref ray-project/ray#34714

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

* Allow pandas 2.0

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

* Remove exclusion markers

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

* Run poetry lock --no-update

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

---------

Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>

* Retry on resource conflict error (#3035)

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* chore: Fix `no space left on device` error in `predictor-runtime-build` (#3049)

* Create a separate action to free-up disk space on GH action runner
* Move 'free-up-disk-space' step outside 'minikube-setup' action
* Free-up disk space before running 'predictor-runtime-build'

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Update MM version to v0.11.0-rc1 (#3047)

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>

* Bump scikit-learn version to 1.3.0 (#3040)

* Bump scikit-learn version to 1.3.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update test models

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Downgrade ray serve to 2.4

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* template out kube-rbac-proxy image (#3048)

* template out kube-rbac-proxy image

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>

* add kserve-addressable-resolver to clusterroles

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>

---------

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>

* Add ARM64 arch support for serving runtimes (#3038)

Except for Paddle, which does not support arm64/aarch64

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Support secret name overrides with annotation (#3034)

* Add annotation for secret name overrides

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Remove the field

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix secret name annotation

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update kserve url storage example docs

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Address review comments

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update config docs for storage secret

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix storage secret name

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add test for secret name annotation override

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix flake8 lint

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* release: Update defaultModelMeshVersion to v0.11.0 (#3059)

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* chore: Rename ModelMesh validating webhook (#3064)

Resolves #3063

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Release v0.11.0 (#3061)

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Update poetry lock files (#3066)

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: ddelange <14880945+ddelange@users.noreply.github.com>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
Co-authored-by: Rafael Vasquez <raf.vasquez@ibm.com>
Co-authored-by: Tessa Pham <hpham111@bloomberg.net>
Co-authored-by: Andrews Arokiam <87992092+andyi2it@users.noreply.github.com>
greenmoon55 pushed a commit to greenmoon55/kserve that referenced this pull request Aug 10, 2023
Resolves kserve#3063

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Jin Dong <jdong183@bloomberg.net>
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
Resolves kserve#3063

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename ModelMesh validating webhook
3 participants
0