Fix certain invalid @lute/ runtime requires giving a nonsensical error
#280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lute/ requires@lute/ runtime requires giving a nonsensical error
aatxe
approved these changes
May 16, 2025
909D
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three cases where we previously had bad error messages
@lute/@lute/foo@lute/..The fix is done by introducing a "lute" alias into the global config, and then checking to see if we are using that alias in the require resolver. If we are, we
luaL_errorout of the require function immediately.Future work
There are more edge cases here! This PR does not fix
@lute/foo/..having a funky error message. However, as@lute/foois the most common mistake, I am still PRing this as it is an improvement.