sleep in "test threadpool with async" is non-deterministic #715

jamessan · 2024-08-31T14:30:12Z

Debian's CI for arm64 has recently started failing this test more often than not.

I increased the sleep to 100 and some local tests show that to be more reliable, but it would be better if there were a deterministic way to know when the async callback has been run.

I was thinking of a semaphore, but I noticed that uv API doesn't appear to be exposed in luv. Open to ideas, but for now I'll probably patch the test to use a longer sleep.

truemedian · 2025-05-18T14:37:55Z

With #774 merged using a semaphore to synchronize thread tests is now fair game.

…en async work is done On slow / busy systems, it may take longer than 10ms for the async callback to run. When this happens, the test process typically crashes since the async context has already been freed by the time it finally gets scheduled to run. Using a semaphore ensures the work is done before continuing through the test. Closes: luvit#715

jamessan mentioned this issue May 18, 2025

fix(test-work): use semaphore, instead of arbitrary sleep, to know when async work is done #775

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sleep in "test threadpool with async" is non-deterministic #715

sleep in "test threadpool with async" is non-deterministic #715

sleep in "test threadpool with async" is non-deterministic #715

sleep in "test threadpool with async" is non-deterministic #715

Comments