8000 Switch to Python 3 by aneeshusa · Pull Request #100 · lyft/metadataproxy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch to Python 3 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Switch to Python 3 #100

merged 2 commits into from
Apr 6, 2020

Conversation

aneeshusa
Copy link
Contributor

No description provided.

@aneeshusa aneeshusa requested a review from ryan-lane April 3, 2020 16:07
@@ -1,6 +1,6 @@
language: python
python:
- "2.7"
- "3.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this repo but it may be good to run tests against more recent versions of Python too? (though it gets tricky with the docker_push.sh script and stuff like that, so probably something to address in another PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked this since it matches what we use internally - agreed that another PR can look into extending the test matrix.

Copy link
Contributor
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no tests 😓

@skiptomyliu
Copy link
Member

+1

@aneeshusa
Copy link
Contributor Author

Did some internal testing on this change.

@aneeshusa aneeshusa merged commit c824e89 into master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0