Add an option to patch boto to support ecs-server mode of aws-vault #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
BA17
div class="d-flex flex-md-row flex-column">
skiptomyliu
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-vault supports running as an ecs-server, which runs on a random port, on localhost, with a required token. It puts the URL into the environment, and metadataproxy will use that URL, if it's set in the environment. However, docker for mac only allows access to the host through a special hostname. Botocore limits access to a hardcoded set of hostnames and IPs for the URL.
This change patches botocore to inject a provided hostname, if it's set in the environment.