simplify getPosition #1161
Merged
simplify getPosition #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's only used in byPtr mode. This removes the need to transfer `base` ptr value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's only used in
byPtrmode.This makes it possible to remove the
baseparameter.Removing the need for
basepointer is what will make it possible to remove the last remaining pointer overflow UB warnings. However, previous attempt to completely removebaseresulted in substantial speed decrease.This PR implements a much smaller step in this direction, which is presumed to be performance neutral.
It is, as measured on benchmark. Some compilers will even generate exactly the same binary.