8000 Recognize and decompress files created by Mozilla by UnitedMarsupials · Pull Request #1259 · lz4/lz4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Recognize and decompress files created by Mozilla #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Recognize and decompress files created by Mozilla #1259

wants to merge 7 commits into from

Conversation

UnitedMarsupials
Copy link

This aims to address the decompression part of the #880.

The compression part -- creation of files usable by Mozilla -- may be more contentious, given the reluctance to support the proliferation of the bogus formats.

(Personally, I need to be able to (sometimes) decompress Mozilla files, modify them, and then compress the modified data back for Firefox and/or Thunderbird to process.)

Mikhail T and others added 7 commits August 26, 2023 17:15
Recognize and decode files created by Mozilla
17d4f70 
Issue:	lz/lz#880
Fix warnings thrown by -std=c90.
15cb219 
This uglifies the code, but seems required by the lz4's regression
testing.
Another warning fixed -- loss of integer precision
0016836
Use UTIL_fileno() to build safely on Windows
090c4f5
Make the new code (Mozilla-flavor) work with irregular files
6b0b58a 
That is, improve falling back for when mmap-ing fails.
Explicitly cast malloc's result to char *
b2bfede 
Why does void* need explict casting to another pointer, I do not
understand...
8000 Address compiler warnings, simplify #ifdefs
105f997 
Also, add "\n" to debug-messages, where it was missing.
@Cyan4973
Copy link
Member

This is good work,
but I'm not convinced that this repository is the best place to host it.
I would rather see it as a dedicated fork, or tool, focused on its mission to decode (and eventually produce) mozilla format.

@UnitedMarsupials
Copy link
Author

I would rather see it as a dedicated fork

What good is a fork at all?!

or tool, focused on its mission to decode (and eventually produce) mozilla format.

The existing lz4 already supports multiple different formats -- recognizing a multitude of "magic" numbers. If those aren't all split into separate tools of their own, why "pick" on the Mozilla's "flavor"?

@Cyan4973
Copy link
Member

If your concern is discoverability, a reasonable trade-off I can propose is to host a dedicated lz4-mozilla reader (and maybe generator) as part of the contrib/ directory, within this repository.

@UnitedMarsupials
Copy link
Author

host a dedicated lz4-mozilla reader

Such readers already exist :) I even maintain one of them for FreeBSD. I deliberately made this change to match the style and the spirit of this repository...

I still don't understand, why you hesitate to add one more "flavor".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnitedMarsupials @Cyan4973
0