lz4: remove unnecessary check of ip #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With clang-16 and silesia, observed ~1.8 - 3% compression uplift for level-1/2 on Arm N1/N2, Apple M1 and Xeon 5218. |
Cyan4973
reviewed
Oct 23, 2023
ip has been advanced before the match finder loop, so (ip>anchor) will be always true before entering the loop. This change generates better codegen with clang. Change-Id: I2567cb7f4a16cc28496fc88c07dcd99601bc97b3 Signed-off-by: Jun He <jun.he@arm.com>
Cyan4973
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip has been advanced before the match finder loop, so (ip>anchor) will be always true before entering the loop.
This change generates better codegen with clang.
Change-Id: I2567cb7f4a16cc28496fc88c07dcd99601bc97b3