This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Fix collisions between $config property of OAuth client and HTTP client #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t HTTP client 2.1.0 made changes to internal protected members, refactoring those that were prefixed with an underscore to remove the underscore. Unfortunately, one of these, `Laminas\OAuth\Client::$config`, is also defined in the parent `Laminas\Http\Client`, and the two were of different types, leading to type errors (see laminas/laminas-twitter#6). I've audited to determine what collisions exist, and this was the only one found. As such, I've renamed the property, as well as all references to it internally, to avoid the collision. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1.0 made changes to internal protected members, refactoring those that were prefixed with an underscore to remove the underscore.
Unfortunately, one of these,
Laminas\OAuth\Client::$config, is also defined in the parentLaminas\Http\Client, and the two were of different types, leading to type errors (see laminas/laminas-twitter#6).I've audited to determine what collisions exist, and this was the only one found.
As such, I've renamed the property, as well as all references to it internally, to avoid the collision.