8000 fix: panic caused by reading empty posting list by BubbleCal · Pull Request #4019 · lancedb/lance · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: panic caused by reading empty posting list #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

fix: panic caused by reading empty posting list #4019

merged 2 commits into from
Jun 17, 2025

Conversation

BubbleCal
Copy link
Contributor
@BubbleCal BubbleCal commented Jun 17, 2025 •
edited
Loading

it happens only if all conditions satisfied:

  • search with new search algo (block max wand), this means it's on the version that new FTS format has been introduced
  • the FTS index is still in legacy format
  • some posting list produces a candidate doc, that its doc id is greater than the first posting list's max doc id

@BubbleCal
fix: panic caused by reading empty posting list
87718aa 
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Jun 17, 2025
@BubbleCal
remove debug logs
4338d42 
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal requested review from westonpace and wjones127 and removed request for westonpace June 17, 2025 08:56
@BubbleCal BubbleCal marked this pull request as ready for review June 17, 2025 08:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (201a94d) to head (4338d42).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/inverted/index.rs 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
+ Coverage   78.37%   78.42%   +0.05%     
==========================================
  Files         285      285              
  Lines      111635   111697      +62     
  Branches   111635   111697      +62     
==========================================
+ Hits        87494    87601     +107     
+ Misses      20757    20714      -43     
+ Partials     3384     3382       -2
Flag Coverage Δ
unittests 78.42% <97.91%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BubbleCal BubbleCal merged commit 77bbcb2 into lancedb:main Jun 17, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BubbleCal @codecov-commenter @westonpace
0