feat: add cache stats for new cache #4024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4024 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.01%
==========================================
Files 285 285
Lines 113487 113471 -16
Branches 113487 113471 -16
==========================================
- Hits 89305 89289 -16
- Misses 20746 20761 +15
+ Partials 3436 3421 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westonpace
approved these changes
Jun 19, 2025
rust/lance-core/src/cache.rs
Outdated
Comment on lines
219
to
223
| #[derive(Debug, Clone)] | ||
| pub struct CacheStats { | ||
| pub hits: u64, | ||
| pub misses: u64, | ||
| } |
There was a problem hiding this comment.
It's probably self-evident but maybe briefly document this struct since it goes out the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to compute the hit and miss rate of the caches.