feat: enhancing java LanceFileReader by adding projection push down and ranges lookup functionality #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and projection pushdown functionalities.
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
yanghua
requested changes
May 28, 2025
There was a problem hiding this comment.
@leaves12138 thanks for your contribution. Left some comments.
java/core/src/main/java/com/lancedb/lance/file/LanceFileReader.java
Outdated
Show resolved
Hide resolved
java/core/src/main/java/com/lancedb/lance/file/LanceFileReader.java
Outdated
Show resolved
Hide resolved
yanghua
reviewed
May 29, 2025
|
|
||
| try (ArrowReader batches = | ||
| reader.readAll( | ||
| null, Arrays.asList(Range.of(1, 11), Range.of(14, 19), Range.of(20, 21)), 100)) { |
There was a problem hiding this comment.
What's behavior about Range.of(1, 14), Range.of(11, 19), Range.of(20, 21)?
There was a problem hiding this comment.
It takes rows of [1,2,3,4,5,6,7,8,9,10,14,15,16,17,18,20]. It divided to range [1,11], [14,19], [20,21]
Just for test, random choose. Make sure multiple ranges will not cause an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inhance java LanceFileReader function, allow projection push down and ranges lookup push down.