Add "set" into function names for adjusting drawing state #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzimuzhi
requested changes
Jun 13, 2025
Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
FrankMittelbach
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
I think @muzimuzhi is right and I was wrong on the remaining functions and that should be resolved, otherwise I think it looks fine
muzimuzhi
approved these changes
Jun 14, 2025
|
Minor addition: As now "set" is added into all function names documented under section "Graphics state", maybe it's a chance to also rename that section to "Setting graphics state". latex3/l3experimental/l3draw/l3draw.dtx Lines 261 to 265 in 585dbdb Also, in "some are rest at the start of each drawing", is "rest" a typo for "reset"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.