Pragma to force function inlining #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlb
approved these changes
Sep 23, 2024
src/rewriter.fs
Outdated
| forceInlineNextFunction <- None | ||
| Some tl | ||
| | tl -> Some tl | ||
| let li = li |> List.choose processPragmas |
There was a problem hiding this comment.
not let needed: li |> List.choose processPragmas |>
src/rewriter.fs
Outdated
| let mutable forceInlineNextFunction = None | ||
| let processPragmas tl = | ||
| match tl with | ||
| | TLDirective ["#pragma function inline"] -> |
There was a problem hiding this comment.
String matching is very restricted and will fail if there's any extra whitespace.
In theory, we could parse the pragmas in the parser.
There was a problem hiding this comment.
I'll accept multiple spaces. But I'm not so sure that the parser is the best place to process a format that's specific to minifier rather than specific to the language.
| | None -> () | ||
| forceInlineNextFunction <- None | ||
| Some tl | ||
| | tl -> Some tl |
There was a problem hiding this comment.
What if #pragma function inline is not followed by a function?
Do we want to handle that case?
There was a problem hiding this comment.
We could emit a warning for unused function inline pragmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.