More function overloading in output #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we any closer to the minifier having full visibility into expression types? |
|
No. This optimization doesn't actually need type information (it just looks at the function signature and decides if overloading is possible). We can discuss expression types in a separate issue (I don't think it's difficult to do). |
laurentlb
added a commit
to ctrl-alt-test/moto
that referenced
this pull request
Oct 3, 2024
- This includes aggressive overloading of functions (laurentlb/shader-minifier#465)
|
I've updated the PR, with tests and documentation. Compression tests show it's very useful. |
eldritchconundrum
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function overloading makes the code much more compressible, as many functions will have the same name (assuming that the file has many functions). When tested on an 8kB intro, this change saved 100 bytes (after compression). Some users reported modest gains on 4kB intros.
Fixes #383