Identifying clients with their User-Agent header
#1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connection. Adding documentation for client libraries to include the User-Agent header
duncte123
suggested changes
Mar 7, 2025
LavalinkServer/src/main/java/lavalink/server/io/SocketServer.kt
Outdated
Show resolved
Hide resolved
LavalinkServer/src/main/java/lavalink/server/io/SocketContext.kt
Outdated
Show resolved
Hide resolved
LavalinkServer/src/main/java/lavalink/server/io/SocketServer.kt
Outdated
Show resolved
Hide resolved
LavalinkServer/src/main/java/lavalink/server/io/SocketServer.kt
Outdated
Show resolved
Hide resolved
LavalinkServer/src/main/java/lavalink/server/io/UserAgentContextFilter.kt
Show resolved
Hide resolved
…gent on socket message sending
…hutdowns also log the userAgent
duncte123
approved these changes
Mar 16, 2025
topi314
requested changes
Apr 12, 2025
There was a problem hiding this comment.
I just tested this and there are a few places where this seems to be missing:
- https://github.com/holasoyender/Lavalink/blob/b7ccf2121c2e608fb2f24f627db5fb2f4a2ddc85/LavalinkServer/src/main/java/lavalink/server/io/SocketContext.kt#L249
- https://github.com/holasoyender/Lavalink/blob/b7ccf2121c2e608fb2f24f627db5fb2f4a2ddc85/LavalinkServer/src/main/java/lavalink/server/io/SocketContext.kt#L174
- https://github.com/holasoyender/Lavalink/blob/b7ccf2121c2e608fb2f24f627db5fb2f4a2ddc85/LavalinkServer/src/main/java/lavalink/server/io/SocketContext.kt#L178
- https://github.com/holasoyender/Lavalink/blob/b7ccf2121c2e608fb2f24f627db5fb2f4a2ddc85/LavalinkServer/src/main/java/lavalink/server/player/EventEmitter.kt#L92
additionally your logging format is too different from how lavalink logs used to look
old:
2025-04-12T17:42:28.957+02:00 TRACE 28436 --- [Lavalink] [ XNIO-1 I/O-9] lavalink.server.io.SocketContext : Sent {"op":"playerUpdate","state":{"time":1744472548956,"position":0,"connected":true,"ping":0},"guildId":"1082302532421943407"}
new:
--2025-04-12T17:38:59.899+02:00 -TRACE 9496 --- [ XNIO-1 I/O-15] lavalink.server.io.SocketContext Sent {"op":"playerUpdate","state":{"time":1744472339898,"position":114960,"connected":true,"ping":7},"guildId":"1082302532421943407"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion that was discussed on the Discord support server. Related to lavalink-devs/lavalink-client#34, #1135 and holasoyender/lavalink-client@8dfaf59
This pull request adds the option for clients to set a
User-Agentheader on socket connections and HTTP requests to set extra information about the bot.Headers example (for websockets)
Headers example (for http requests)
When the
User-Agentheader is set, every log will have a prefix to identify the client its coming from.