8000 Fix JEI with later-loading compat by uecasm · Pull Request #10855 · ldtteam/minecolonies · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix JEI with later-loading compat #10855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Fix JEI with later-loading compat #10855

merged 2 commits into from
May 14, 2025

Conversation

uecasm
Copy link
Contributor
@uecasm uecasm commented May 12, 2025

Closes #10834

Changes proposed in this pull request

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (do not port)

Copy link
Contributor
@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with reloading as well? (I.e. adding datapack and reloading datapacks)

@uecasm
Copy link
Contributor Author
uecasm commented May 12, 2025

Hmm. No, it doesn't, because the timing of that is different and makes things more awkward.

@uecasm
Copy link
Contributor Author
uecasm commented May 12, 2025

Now it does. Also fixed a related pre-existing bug.

@Raycoms Raycoms merged commit dc59701 into version/1.21 May 14, 2025
5 checks passed
@Raycoms Raycoms deleted the fix/jei-compat branch May 14, 2025 19:40
@uecasm uecasm mentioned this pull request May 26, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0