Fix soy bottle duplication #10869
Merged
Fix soy bottle duplication #10869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
reviewed
May 15, 2025
| } | ||
|
|
||
| @Override | ||
| public void toNetwork(@NotNull final FriendlyByteBuf buf, |
There was a problem hiding this comment.
That feels like a lot of methods, do we need all of them? I thought this should be more of a straightforward copy of shapeless with only the remainingitems changing
There was a problem hiding this comment.
That's exactly what it is. Though I lumped the Builder in there too, whereas with Shapeless it's in a separate file.
Pretty sure it will get shorter in 1.21, where a lot of this will be codecs instead, but I haven't looked closely at that yet.
Raycoms
previously approved these changes
May 16, 2025
(cherry picked from commit f2a7100)
2 tasks
someaddons
previously approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10863
Changes proposed in this pull request
Testing
Review please (do not port; will need changes)